[go-migration] Add dependencies to application classpath after staging#1208
Open
kiril-keranov wants to merge 5 commits intocloudfoundry:feature/go-migrationfrom
Open
[go-migration] Add dependencies to application classpath after staging#1208kiril-keranov wants to merge 5 commits intocloudfoundry:feature/go-migrationfrom
kiril-keranov wants to merge 5 commits intocloudfoundry:feature/go-migrationfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR addresses issues related to not adding corresponding framework jar dependencies to the application classpath after staging.
The corresponding dependencies frameworks that should provide jars to the application classpath are now fixed to append to the
CLASSPATHenv sourced fromprofile.d. Instead of rewriting a CLASSPATH variable indeps/index/envthey provide sh scripts in theprofile.dfolder which assemble theCLASSPATHenv when sourced.tomcatandspring-bootcontainers never considered these dependencies to be added to the classpath on issuing the final release command. They are now adjusted to provide a shell script that will build symlinks to these dependencies in the correspondingWEB-INF/liborBOOT-INF/libapplication dependencies folders in order for the dependencies to be subject of classloading.Addresses issue