Skip to content

feat: make dropdown component public#4345

Open
mxschll wants to merge 51 commits intomainfrom
dev-v3-schomax-dropdown-component
Open

feat: make dropdown component public#4345
mxschll wants to merge 51 commits intomainfrom
dev-v3-schomax-dropdown-component

Conversation

@mxschll
Copy link
Member

@mxschll mxschll commented Mar 11, 2026

Description

  • Exposes the internal dropdown component and refactors existing components/pages to use public version.
  • Introduces test utils for dropdown.
  • Adds style api to dropdown.

Related links, issue #, if available: RGJgABPXohP8

How has this been tested?

Changes went through the pipeline without visual regressions.

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Mar 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.45%. Comparing base (3189432) to head (470d83a).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4345   +/-   ##
=======================================
  Coverage   97.45%   97.45%           
=======================================
  Files         902      905    +3     
  Lines       26451    26506   +55     
  Branches     9530     9553   +23     
=======================================
+ Hits        25777    25832   +55     
  Misses        631      631           
  Partials       43       43           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

*/
ariaDescribedby?: string;

/**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this necessary since the entire component is Core-only anyway?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd leave it here for the sake of consistency, as well as for future use in case we want to expose the component to the console (probably unlikely), so we can keep the style API core only. Or is this concern unjustified?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not blocking, as this doesn't break anything


export namespace DropdownProps {
export interface Style {
dropdown?: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are the properties actually nested under dropdown? Is it because there is also the trigger, although we don't consider styling it for now?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I wanted to go with root initially but that's also not ideal as we need to style the :after element which is used to display the border as well as the dropdown wrapper to change border radius and background. So I grouped it in dropdown. Since the trigger is custom, we probably could remove this nesting entirely...

*/
ariaDescribedby?: string;

/**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not blocking, as this doesn't break anything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants