Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4345 +/- ##
=======================================
Coverage 97.45% 97.45%
=======================================
Files 902 905 +3
Lines 26451 26506 +55
Branches 9530 9553 +23
=======================================
+ Hits 25777 25832 +55
Misses 631 631
Partials 43 43 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
83163a8 to
984214f
Compare
| */ | ||
| ariaDescribedby?: string; | ||
|
|
||
| /** |
There was a problem hiding this comment.
Is this necessary since the entire component is Core-only anyway?
There was a problem hiding this comment.
I'd leave it here for the sake of consistency, as well as for future use in case we want to expose the component to the console (probably unlikely), so we can keep the style API core only. Or is this concern unjustified?
There was a problem hiding this comment.
Not blocking, as this doesn't break anything
|
|
||
| export namespace DropdownProps { | ||
| export interface Style { | ||
| dropdown?: { |
There was a problem hiding this comment.
Why are the properties actually nested under dropdown? Is it because there is also the trigger, although we don't consider styling it for now?
There was a problem hiding this comment.
Yes, I wanted to go with root initially but that's also not ideal as we need to style the :after element which is used to display the border as well as the dropdown wrapper to change border radius and background. So I grouped it in dropdown. Since the trigger is custom, we probably could remove this nesting entirely...
| */ | ||
| ariaDescribedby?: string; | ||
|
|
||
| /** |
There was a problem hiding this comment.
Not blocking, as this doesn't break anything
cf41e41 to
a78c967
Compare
Description
Related links, issue #, if available:
RGJgABPXohP8How has this been tested?
Changes went through the pipeline without visual regressions.
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.