feat: Add findItemById test-util to FlashbarWrapper#4367
Draft
johannes-weber wants to merge 1 commit intomainfrom
Draft
feat: Add findItemById test-util to FlashbarWrapper#4367johannes-weber wants to merge 1 commit intomainfrom
johannes-weber wants to merge 1 commit intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4367 +/- ##
=======================================
Coverage 97.45% 97.45%
=======================================
Files 902 902
Lines 26468 26471 +3
Branches 9539 9541 +2
=======================================
+ Hits 25794 25797 +3
+ Misses 668 631 -37
- Partials 6 43 +37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
691772a to
116c6e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
findItemById(id)method toFlashbarWrappertest utility, allowing users to target individual flash items by theiridproperty during testing.This is useful for console flows with multiple sequential API calls that each generate separate flash notifications (e.g., create resource → configure settings). Tests can now assert on specific flashes by ID instead of relying on positional indexing.
The method reuses the existing
data-itemidattribute already rendered on flash items — no changes to the Flashbar component source.Related links, issue #, if available: AWSUI-61831
How has this been tested?
Unit tests (non-collapsible and collapsible flashbar), integration test.
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.