Open
Conversation
Add optional context parameter to remaining form-filling methods
(appendField, clearField, attachFile) across Playwright, Puppeteer,
and WebDriver helpers for consistency with fillField, selectOption,
checkOption, and uncheckOption which already support it.
This allows scoping element search to a specific DOM container:
I.appendField('Name', 'jon', '.form-container')
I.clearField('Name', '.form-container')
I.attachFile('Avatar', 'data/avatar.jpg', '.form-container')
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…achFile Add shared webapi tests verifying that context scoping works for appendField, clearField, and attachFile. Extended the context.php test page with pre-filled values and file inputs to support the tests. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…pers Remove unused `options` parameter from Playwright's clearField. The options were accepted but never passed to the underlying clear() call. Now all helpers have consistent `clearField(locator, context)` signature. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add Within() function with three signatures: - Within(locator) to begin scoped context - Within() to end current context - Within(locator, fn) callback pattern (existing behavior) Lowercase within() kept as deprecated alias with one-time warning. switchTo() in helpers auto-ends any active Within context. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
DenysKuchma
requested changes
Mar 9, 2026
| if (this.withinLocator) { | ||
| await this._withinEnd() | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
WithinContext.endCurrent() ? to properly clear the context.
| if (this.withinLocator) { | ||
| await this._withinEnd() | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
WithinContext.endCurrent() ? to properly clear the context.
| if (this.withinLocator) { | ||
| await this._withinEnd() | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
WithinContext.endCurrent() ? to properly clear the context.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
within()intoWithin()with three calling patterns:Within('.ctx')...Within()— new, no callback neededWithin('.new')auto-ends any active contextWithin('.ctx', () => { ... })— existing behavior preservedwithin()kept as deprecated global alias with one-time console warningWithinmust be imported:import { Within } from 'codeceptjs/effects'(no global registration)switchTo()in Playwright, Puppeteer, and WebDriver auto-ends any active Within contextWithinContextclass inlib/step/within.js(modeled onSection)docs/within.mdwith examples for iframes, page objects, await usageFiles changed
lib/step/within.jsWithinContextclass +WithinSteplib/effects.jsWithinwith 3 signatures, deprecatedwithinaliaslib/index.jsWithinlib/helper/Playwright.jsswitchTo()lib/helper/Puppeteer.jsswitchTo()lib/helper/WebDriver.jsswitchTo()docs/within.mddocs/effects.mdtest/acceptance/within_test.jsTest plan
within()shows one-time warning and still worksWithin🤖 Generated with Claude Code