Issue 147 remove or replace footer quick links#149
Open
Games4Doritos wants to merge 3 commits intomainfrom
Open
Issue 147 remove or replace footer quick links#149Games4Doritos wants to merge 3 commits intomainfrom
Games4Doritos wants to merge 3 commits intomainfrom
Conversation
- Removed gamedev-metadata.json as it was redundant only storing data for the club's social media links. The data for the se links has been moved to Footer.tsx in the form of a list of objects - Added the social media link for the club's new itch.io page - Removed all of the quick links from the footer, as they were useless. To rework the footer's layout from this, the column number at lg width has been reduced to 2 since only two segments remain. When at 2 columns, the 'Explore' links will be centered within their column, but will justify left when wrapping. Made some label changes: - Replaced Create . Play . Inspire, with Design . Create . Play, as that is the slogan we are currently choosing. - Removed the email text and href from where the email is stated in the footer, as we currently don't have an email and that one doesn't exist. - Changed the text below the email to say 'Building the next generation of game developers!', which sounds better + the previous version was grammatically incorrect - Changed the copyright holder to 'CFC ~ GDUWA', as the previous title was poor.
- Added a wrapper div in the copyright segment so the text correctly wraps instead of being weird - Added a wrapper div to the constitution button to set an invisible width for centering - Added a wrapper <pre> in the 'Made with love' segment so the text doesn't act weird when supposed to wrap - Added a width of 48 (tailwind) to all three segments at sm width. This width will keep the 'made with love' message to one line and allow all three segments to be equally spaced compared to before. Copyright text will appropriately wrap - Added a width of 80 (tailwind) to all three segments at lg width. This width will keep all messages to one line and still evenly spaced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
There were a few issues with the footer, so this is more of a general footer fix pr than just the issue. This pr firstly removes the quick links section of the original footer, removes the gamedev-metadata.json file which only stored social media info (moved to footer.tsx) so only the explore links remain, changes some errors with the bottom section of the footer to do with centering and responsiveness, and fixes some grammatical errors/opinionated text changes.
New footer:
Recording.2026-03-16.124858.mp4
Old weird behaviour:
Change Form
Related issue