Add AddQueryResource alternatives for bulk unpublish query params in …#135
Closed
OMpawar-21 wants to merge 2 commits intodevelopmentfrom
Closed
Add AddQueryResource alternatives for bulk unpublish query params in …#135OMpawar-21 wants to merge 2 commits intodevelopmentfrom
OMpawar-21 wants to merge 2 commits intodevelopmentfrom
Conversation
…BulkUnpublishService.cs.
Description
In BulkUnpublishService.cs, two comment-only lines were added to document an alternative way of sending the bulk unpublish options:
skip_workflow_stage_check – A commented call AddQueryResource("skip_workflow_stage_check", "true") was added next to the existing Headers["skip_workflow_stage_check"] = "true" assignment.
approvals – A commented call AddQueryResource("approvals", "true") was added next to the existing Headers["approvals"] = "true" assignment.
OMpawar-21
requested review from
cs-raj and
sunil-lakshman
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request: Add commented AddQueryResource alternatives in BulkUnpublishService (DX-3233)
Summary
Documents an alternative way to pass bulk unpublish options by adding commented
AddQueryResourcecalls inBulkUnpublishService.cs. No behavior change; options are still sent via request headers only.Changes
Contentstack.Management.Core/Services/Stack/BulkOperation/BulkUnpublishService.cs// AddQueryResource("skip_workflow_stage_check", "true");next toHeaders["skip_workflow_stage_check"] = "true";// AddQueryResource("approvals", "true");next toHeaders["approvals"] = "true";Rationale
The comments serve as a reference for sending these options as query parameters via
AddQueryResourceinstead of (or in addition to) headers, e.g. for API compatibility or future refactors.Testing
Related