Fix tests for cross-platform compatibilit#161
Open
denini08 wants to merge 3 commits intodalibo:masterfrom
Open
Fix tests for cross-platform compatibilit#161denini08 wants to merge 3 commits intodalibo:masterfrom
denini08 wants to merge 3 commits intodalibo:masterfrom
Conversation
Member
|
Thanks a lot for your contribution. Unfortunately, we don't officially support Windows and we probably won't in a near future. Moreover we don't have any CI running on Windows so even if this fixes an issue, we can't make sure it does and will continue to work in the future. |
Author
|
Hi @pgiraud I get that Windows isn’t officially supported. I just thought this change wouldn’t hurt, won’t affect behavior on Linux/macOS, and might help anyone running tests on Windows. Thanks for considering! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #160
This PR fixes test failures on Windows caused by differences in file paths and line endings.
These changes make the tests pass on Windows while keeping compatibility with Linux and mac. I’m happy to help, and let me know what you think.