Skip to content

fix: cleanup debug prints and wire ENUM/SET dropdown into right sidebar#155

Merged
datlechin merged 5 commits intomainfrom
fix/cleanup-debug-prints-and-enum-sidebar
Mar 3, 2026
Merged

fix: cleanup debug prints and wire ENUM/SET dropdown into right sidebar#155
datlechin merged 5 commits intomainfrom
fix/cleanup-debug-prints-and-enum-sidebar

Conversation

@datlechin
Copy link
Owner

Summary

  • Remove 16 debug print() statements and an unused logger left over from ENUM/SET dropdown debugging
  • Wire ENUM/SET enum values from tab.columnEnumValues into the right sidebar's EditableFieldView so the dropdown picker appears for ENUM/SET columns
  • Add metadataVersion to InspectorTrigger so the sidebar reconfigures when Phase 2b loads enum values
  • Extend sidebar picker condition to include SET columns (previously only ENUM)

Test plan

  • Open a MySQL/MariaDB table with ENUM and SET columns
  • Select a row and verify the right sidebar shows dropdown pickers for ENUM/SET fields
  • Verify no debug prints appear in console output
  • Verify single-click dropdown still works in the data grid for ENUM/SET columns

@chatgpt-codex-connector
Copy link

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@datlechin datlechin force-pushed the fix/cleanup-debug-prints-and-enum-sidebar branch from f6c04c6 to 5631d6a Compare March 3, 2026 11:56
- Clear stale sidebar edits after refresh/discard
- Show green dot for data grid edits in sidebar
- Keep enum/set dropdown visible when NULL/DEFAULT is pending
- Make dropdown clickable on full field area
- Fix InspectorTrigger tests for metadataVersion parameter
- Add MultiRowEditState tests for external modifications and edit clearing
@datlechin datlechin merged commit 2998190 into main Mar 3, 2026
1 check passed
@datlechin datlechin deleted the fix/cleanup-debug-prints-and-enum-sidebar branch March 3, 2026 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant