feat: Add TencentOS Server to supported distributions#549
Open
guoningzhang20 wants to merge 1 commit intodocker:masterfrom
Open
feat: Add TencentOS Server to supported distributions#549guoningzhang20 wants to merge 1 commit intodocker:masterfrom
guoningzhang20 wants to merge 1 commit intodocker:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Docker convenience install script (
install.sh) does not recognize TencentOS Server (ID=tencentos) as a supported distribution. When run on TencentOS, the script exits withERROR: Unsupported distribution 'tencentos'.TencentOS Server is a RHEL-based distribution maintained by Tencent Cloud, fully compatible with the CentOS/RHEL ecosystem. It uses
dnfas its package manager and can use CentOS Docker repositories directly.Changes
Modified
install.shto addtencentossupport in three places:case "$lsb_dist"): Addedtencentosalongsidecentos|rhelto correctly extractVERSION_IDfrom/etc/os-release.case "$lsb_dist"): Addedtencentosalongsidecentos|fedora|rhelto enable the RPM-based installation path.tencentosto thecentosDocker repository, since Docker does not maintain a separate TencentOS repository.TencentOS Server Info
ID=tencentos,ID_LIKE="tencentos",PLATFORM_ID="platform:el9"Testing
Verified on TencentOS Server V4.4 (x86_64) that the modified script: