Skip to content

feat: add ModelScope for ListTaskEntriesRequest#638

Merged
gaius-qi merged 1 commit intomainfrom
feature/model-scope-list
Mar 9, 2026
Merged

feat: add ModelScope for ListTaskEntriesRequest#638
gaius-qi merged 1 commit intomainfrom
feature/model-scope-list

Conversation

@gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Mar 9, 2026

Description

This pull request introduces support for the ModelScope protocol in the ListTaskEntriesRequest message across the codebase. The changes add a new optional model_scope field, update validation logic, and increment the package version.

Addition of ModelScope protocol support:

  • Added an optional model_scope field of type common.v2.ModelScope to the ListTaskEntriesRequest message in proto/dfdaemon.proto and pkg/apis/dfdaemon/v2/dfdaemon.proto. [1] [2]
  • Updated the Rust struct ListTaskEntriesRequest in src/dfdaemon.v2.rs to include the new model_scope field.

Validation logic updates:

  • Enhanced the validate method for ListTaskEntriesRequest in pkg/apis/dfdaemon/v2/dfdaemon.pb.validate.go to handle validation for the new ModelScope field, supporting both ValidateAll and Validate interfaces.

Version bump:

  • Incremented the package version in Cargo.toml from 2.2.23 to 2.2.24 to reflect the new feature addition.

Related Issue

Motivation and Context

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi self-assigned this Mar 9, 2026
@gaius-qi gaius-qi added the enhancement New feature or request label Mar 9, 2026
Copy link

@BraveY BraveY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 2769929 into main Mar 9, 2026
6 checks passed
@gaius-qi gaius-qi deleted the feature/model-scope-list branch March 9, 2026 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants