Skip to content

Upgrade tonic to 0.14.3, tonic-reflection and tonic-health to 0.14.3#1721

Merged
gaius-qi merged 8 commits intomainfrom
copilot/update-tonic-version-0-14-3
Mar 13, 2026
Merged

Upgrade tonic to 0.14.3, tonic-reflection and tonic-health to 0.14.3#1721
gaius-qi merged 8 commits intomainfrom
copilot/update-tonic-version-0-14-3

Conversation

Copy link
Contributor

Copilot AI commented Mar 12, 2026

  • Identify CI failure: Lint job failing due to dead code (copy_task_by_range) and test failures (missing gRPC framing)
  • Fix dead code lint: Add #[allow(dead_code)] to copy_task_by_range in content_linux.rs and content_macos.rs
  • Fix test failures: Add gRPC framing (5-byte header) when using then.bytes() in dfget tests
  • Run cargo fmt --all -- --check to verify formatting
  • Run cargo clippy --all --all-targets -- -D warnings to verify lint
  • Run tests for dfget to verify test fixes
  • Run code review and CodeQL checks

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 2 commits March 12, 2026 11:08
… dragonfly-api to 2.2.25, prost-wkt-types to 0.7, opentelemetry stack, and replace tonic::async_trait

Co-authored-by: gaius-qi <15955374+gaius-qi@users.noreply.github.com>
…for mocktail

Co-authored-by: gaius-qi <15955374+gaius-qi@users.noreply.github.com>
Copilot AI changed the title [WIP] Update tonic, tonic-reflection, and tonic-health to version 0.14.3 Upgrade tonic to 0.14.3, tonic-reflection and tonic-health to 0.14.3 Mar 12, 2026
@gaius-qi gaius-qi marked this pull request as ready for review March 12, 2026 12:18
@gaius-qi gaius-qi added the enhancement New feature or request label Mar 12, 2026
Co-authored-by: gaius-qi <15955374+gaius-qi@users.noreply.github.com>
Copy link

@BraveY BraveY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi enabled auto-merge (squash) March 13, 2026 08:14
Copy link
Member

@EvanCley EvanCley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Mar 13, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.53%. Comparing base (c6a2b95) to head (00646ce).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dragonfly-client/src/grpc/dfdaemon_download.rs 0.00% 1 Missing ⚠️
dragonfly-client/src/grpc/dfdaemon_upload.rs 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1721      +/-   ##
==========================================
- Coverage   50.29%   46.53%   -3.76%     
==========================================
  Files          86       86              
  Lines       21977    24749    +2772     
==========================================
+ Hits        11053    11517     +464     
- Misses      10924    13232    +2308     
Files with missing lines Coverage Δ
dragonfly-client-backend/src/hdfs.rs 40.90% <ø> (ø)
dragonfly-client-backend/src/http.rs 96.97% <ø> (ø)
dragonfly-client-backend/src/hugging_face.rs 35.49% <ø> (ø)
dragonfly-client-backend/src/lib.rs 96.30% <ø> (ø)
dragonfly-client-backend/src/model_scope.rs 42.72% <ø> (ø)
dragonfly-client-backend/src/object_storage.rs 88.77% <ø> (ø)
dragonfly-client-storage/src/content_linux.rs 78.96% <ø> (+0.19%) ⬆️
dragonfly-client-util/src/pool/mod.rs 80.18% <ø> (ø)
dragonfly-client-util/src/request/mod.rs 45.32% <ø> (ø)
dragonfly-client-util/src/request/selector.rs 84.06% <ø> (ø)
... and 3 more

... and 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gaius-qi gaius-qi merged commit e9dbb3f into main Mar 13, 2026
7 checks passed
@gaius-qi gaius-qi deleted the copilot/update-tonic-version-0-14-3 branch March 13, 2026 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants