[doc]Theme generator landing page content added#2410
[doc]Theme generator landing page content added#2410Jialecl wants to merge 9 commits intotheme-generatorfrom
Conversation
raquelarrojo
left a comment
raquelarrojo
left a comment
There was a problem hiding this comment.
With same resolution as in the design there is a blank space between last section and footer:
apps/website/screens/theme-generator/components/LandingCard.tsx
Outdated
Show resolved
Hide resolved
apps/website/screens/theme-generator/components/LandingSteps.tsx
Outdated
Show resolved
Hide resolved
apps/website/screens/theme-generator/components/LandingSteps.tsx
Outdated
Show resolved
Hide resolved
apps/website/screens/theme-generator/components/LandingSteps.tsx
Outdated
Show resolved
Hide resolved
apps/website/screens/theme-generator/components/LandingSteps.tsx
Outdated
Show resolved
Hide resolved
| <DxcFlex direction="column" gap="var(--spacing-gap-ml)" justifyContent="center"> | ||
| <DxcFlex> | ||
| <DxcAvatar icon={icon} color="primary" size="large" shape="square" /> | ||
| </DxcFlex> |
There was a problem hiding this comment.
Why is this flex needed?
There was a problem hiding this comment.
Without the flex the Avatar is distorted by the flex above.
There was a problem hiding this comment.
But this should not happen right? Why is a Flex needed?
There was a problem hiding this comment.
The issue comes from the Avatar component it seems that only the height has been defined with a fixed token.
There are ways to fix it, but for now we should leave this as it is now and fix it in a different PR to make sure that nothing else breaks.
apps/website/screens/theme-generator/components/LandingSteps.tsx
Outdated
Show resolved
Hide resolved
apps/website/screens/theme-generator/components/LandingSteps.tsx
Outdated
Show resolved
Hide resolved
Jialecl
changed the title
- Minor style changes to match the design more closely, such as typography size and divider color. - Added React.Fragment with key to fix the warning about missing keys. - Changing LandingCard to LandingCards to avoid repeating each card.
…b.com/dxc-technology/halstack-react into jialecl/themeGenerator-landingContent
| <DxcFlex direction="column" gap="var(--spacing-gap-ml)" justifyContent="center"> | ||
| <DxcFlex> | ||
| <DxcAvatar icon={icon} color="primary" size="large" shape="square" /> | ||
| </DxcFlex> |
There was a problem hiding this comment.
But this should not happen right? Why is a Flex needed?
| <DxcHeading text="Your brand, fully expressed in Halstack" /> | ||
| <DxcContainer width="70%"> | ||
| <DxcFlex> | ||
| <DxcTypography fontSize="var(--typography-body-xl)" textAlign="center"> |
There was a problem hiding this comment.
The color is not the same as in the design:
2 participants
Checklist
(Check off all the items before submitting)
/libdirectory./websiteas needed.Purpose
Added the rest of the content to the landing page.