Fix artifact download step key for PyTorch and QA test pipelines#2982
Merged
edsavage merged 4 commits intoelastic:mainfrom Mar 12, 2026
Merged
Fix artifact download step key for PyTorch and QA test pipelines#2982edsavage merged 4 commits intoelastic:mainfrom
edsavage merged 4 commits intoelastic:mainfrom
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
valeriy42
approved these changes
Mar 11, 2026
Contributor
valeriy42
left a comment
valeriy42
left a comment
There was a problem hiding this comment.
LGTM. Thank you for fixing this. 🚀
After the build/test step split, build artifacts are uploaded by the build step (key: build_linux-x86_64-RelWithDebInfo), not the test step (key: build_test_linux-x86_64-RelWithDebInfo). Update the artifact download commands to reference the correct step key. Made-with: Cursor
Made-with: Cursor
The build/test split (PR elastic#2914) renamed build step keys from build_test_{platform} to build_{platform}, breaking downstream pipelines (notably appex-qa-stateful-custom-ml-cpp-build-testing) that download artifacts using the old step key. Restore the build_test_ prefix on build steps and give test steps a distinct test_ prefix: Build steps: build_test_{platform} (compile, upload artifacts) Test steps: test_{platform} (download bundle, run tests) This fixes: - QA pipeline artifact download (uses --step build_test_linux-*) - sccache config in post-checkout (build_test_* wildcard now matches build steps that actually compile, not test steps) - Analytics tokens now correctly target test_ steps - DRA creation waits for test_ steps to complete - ES integration tests depend on build_test_ steps Made-with: Cursor
The test_linux-x86_64-RelWithDebInfo-debug step was missing from the BUILDKITE_ANALYTICS_TOKEN conditions, causing the test-collector plugin to fail with exit status 1. Made-with: Cursor
edsavage
force-pushed
the
fix/artifact-download-step-key
branch
from
167bc06 to
3ed28e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run_pytorch_tests.yml.shandrun_qa_tests.yml.shpipelines were still downloading build artifacts from the test step (build_test_linux-x86_64-RelWithDebInfo), which doesn't upload build artifacts.--stepargument to reference the build step (build_linux-x86_64-RelWithDebInfo), which is the step that uploadsbuild/distributions/*.zip.depends_onremains on the test step to ensure downstream tests only trigger after unit tests pass.Fixes: https://buildkite.com/elastic/ml-cpp-pr-builds/builds/2286#019cd609-00cd-424f-aee3-6d5985b979af
Test plan
Made with Cursor