Add Spring Boot Actuator for health endpoint#36
Open
jmjava wants to merge 1 commit intoembabel:mainfrom
Open
Conversation
Resolves embabel#33 - Add spring-boot-starter-actuator dependency - Expose /actuator/health and /actuator/info endpoints - Configure security to permit actuator endpoints without auth - Add ActuatorSecurityTest with 4 regression tests - Configure health details to show only when authorized This provides a proper health check endpoint for CI/CD workflows, monitoring, and orchestration instead of the /api/v1/data/stats workaround currently used by the export-seed workflow. Note: /api/v1/data/stats intentionally remains permitAll() for now. The export-seed CI workflow polls it for readiness detection. A follow-up should: 1. Update export-seed.yml to poll /actuator/health for readiness 2. Move /api/v1/data/stats behind auth (remove from permitAll) This is safe because IngestionRunner is an ApplicationRunner, so the app only accepts requests after ingestion completes — /actuator/health has the same readiness semantics as /api/v1/data/stats. No changes needed to IngestionRunner — it calls dataManager.getStats() directly (in-process), not the HTTP endpoint. All 96 tests pass. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #33
This provides a proper health check endpoint for CI/CD workflows, monitoring, and orchestration instead of the /api/v1/data/stats workaround currently used by the export-seed workflow.
Note: /api/v1/data/stats intentionally remains permitAll() for now. The export-seed CI workflow polls it for readiness detection. A follow-up should:
This is safe because IngestionRunner is an ApplicationRunner, so the app only accepts requests after ingestion completes — /actuator/health has the same readiness semantics as /api/v1/data/stats. No changes needed to IngestionRunner — it calls dataManager.getStats() directly (in-process), not the HTTP endpoint.
All tests pass.