fix: use dynamic upstream variables in nginx dev config#48
Open
rubenhensen wants to merge 1 commit intomainfrom
Open
fix: use dynamic upstream variables in nginx dev config#48rubenhensen wants to merge 1 commit intomainfrom
rubenhensen wants to merge 1 commit intomainfrom
Conversation
Use variable-based upstream definitions with Docker's embedded DNS resolver (127.0.0.11) to prevent nginx from failing to start when upstream containers are not yet available. Also fixes proxy_pass rewriting for /pkg/ and /irma/ locations.
Contributor
Author
|
Double check if this is necessary. Maybe my docker-compose was just having a bad day |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
set $upstream) with Docker's embedded DNS resolver (127.0.0.11) so nginx resolves upstream hostnames at request time rather than at startup/pkg/and/irma/locations using explicitrewriterulesTest plan
docker compose upstarts without nginx errors even if other services are slow to start/pkg/requests are correctly proxied topostguard-pkg:8087/irma/requests are correctly proxied toirma-server:8088