fix: send River favicon to parent shell via postMessage#131
Open
fix: send River favicon to parent shell via postMessage#131
Conversation
The Freenet gateway shell page uses a generic Freenet favicon by default. River's <link rel="icon"> inside the sandboxed iframe doesn't propagate to the parent shell. Send the favicon URL to the parent via the __freenet_shell__ postMessage bridge on initialization so the browser tab shows the River logo. Companion to freenet/freenet-core#3428. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When River runs inside the Freenet gateway's sandboxed iframe, the
<link rel="icon">set by Dioxus only applies within the iframe — it doesn't propagate to the parent shell page's tab icon. The shell page shows a generic Freenet favicon instead of the River logo.Solution
On app initialization, query the
<link rel="icon">element's resolved href and send it to the parent shell via the existing__freenet_shell__postMessage bridge (type: 'favicon'). The shell's bridge JS already handles this message type and updates the parent document's favicon.Testing
cargo check -p river-uipasses[AI-assisted - Claude]