Open
Conversation
|
tobiaskleiner
approved these changes
Mar 19, 2026
Collaborator
tobiaskleiner
left a comment
tobiaskleiner
left a comment
There was a problem hiding this comment.
Thanks @EshitaJoshi for the PR. One comment or suggestion added but nothing that would prevent a merge.
| description = plot_descriptions.get(parameter, "Parameter plot") | ||
| file.write(f"})") | ||
|
|
||
| def _write_dict_table(self, parameter, file, value_data, unit): |
Collaborator
There was a problem hiding this comment.
I believe this logic can largely be replaced by using astropy tables, which handles list-of-dicts to table conversion and can output Markdown directly. It would also help the code to be more stable to inconsistent keys across entries and has unit handling instead of string concatenation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current formatting of parameter values that are a list of dictionaries is very ugly:
Instead, format the list of dictionaries as a table and link the table in the parameter value column like here: