feat(ethexe-processor): charge fee for the first message in announce

[liferooter]

This is the initial implementation of the fee for uploading program state transition onto Ethereum.

[semanticdiff-com]

Review changes with  

Changed Files

File	Status
ethexe/processor/src/handling/run.rs	55% smaller
ethexe/runtime/common/src/lib.rs	27% smaller
core-processor/src/precharge.rs	12% smaller
ethexe/processor/src/host/mod.rs	0% smaller
ethexe/runtime/src/wasm/api/mod.rs	0% smaller
ethexe/runtime/src/wasm/api/run.rs	0% smaller

[gemini-code-assist]

Summary of Changes

Hello @liferooter, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a foundational change to how fees are handled for program state transitions onto Ethereum. It implements a new fee that is charged specifically for the first message processed from a program's queue within a given block, aiming to cover the initial cost of announcing state changes. Concurrently, the PR includes a significant refactoring of the gas charging and allowance checking mechanisms, enhancing the robustness and clarity of the codebase's resource management.

Highlights

• First Message Fee Implementation: Introduced a mechanism to charge a fee for the first message processed from a program's queue within a block, specifically for state transitions announced to Ethereum.
• Gas Charging Logic Refinement: Refactored the gas charging and allowance checking logic across core-processor and utils/builtins-common to utilize new is_enough() and is_not_enough() helper methods on the ChargeResult enum, improving readability and consistency.
• PreChargeGasOperation Extension: Added an Other variant to PreChargeGasOperation in core-processor/src/precharge.rs to support charging for non-standard operations with configurable allowance impact.
• Tracking First Queue Processing: Implemented a HashSet in ethexe/processor/src/handling/run.rs to keep track of programs that have already had their first message processed, ensuring the fee is applied only once per program per block.
• Function Signature Updates: Propagated is_first_queue and ethereum_config parameters through various function signatures in ethexe/processor and ethexe/runtime/common to support the new fee logic.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a fee for processing the first message from a program's queue within a block. This is achieved by adding logic to track which programs have had their queues processed for the first time and charging an extra fee in that case.

The changes include:

• A new is_first_queue flag is plumbed through the execution path to process_queue.
• process_queue now asserts that it's not called on an empty queue and charges a fee for the first message.
• The ChargeResult enum has been improved with is_enough() and is_not_enough() helper methods, and their usage has been adopted throughout the codebase for better readability.

The implementation is solid. I have one suggestion regarding the creation of configuration structs within process_queue, which could be moved to a higher level for better efficiency. Overall, this is a good initial implementation of the feature.

[ark0f]

Also, add test fee is actually charged once