chore(ethexe): append max-chain-len-for-announces-response cli param

[grishasobol]

No description provided.

[semanticdiff-com]

Review changes with  

Changed Files

File	Status
ethexe/network/src/db_sync/responses.rs	74% smaller
ethexe/network/src/lib.rs	48% smaller
ethexe/cli/src/params/network.rs	1% smaller
ethexe/network/src/db_sync/mod.rs	0% smaller

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the network service by making the maximum chain length for announces responses configurable. This change provides greater control over network resource usage and helps prevent potential abuse by allowing the limit to be adjusted via a new CLI parameter, rather than relying on a fixed internal constant.

Highlights

• New CLI Parameter: A new command-line interface parameter, max-chain-len-for-announces-response, has been introduced to allow users to configure the maximum allowed chain length in network announces responses.
• Configurable Announce Response Limit: The previously hardcoded maximum chain length for announces responses has been replaced with a configurable value, enhancing flexibility and control over network behavior.
• Integration Across Network Components: The new configuration setting has been integrated into the network service's configuration, behavior, and database synchronization logic, ensuring consistent application of the limit.

Changelog

• ethexe/cli/src/params/network.rs
  • Added a new CLI parameter max-chain-len-for-announces-response to configure the maximum chain length for announces responses.
  • Integrated the new parameter into the NetworkParams::to_config and MergeParams implementations.
• ethexe/network/src/db_sync/mod.rs
  • Imported DEFAULT_MAX_CHAIN_LEN_FOR_ANNOUNCES_RESPONSE and NonZeroU32.
  • Updated the db_sync::Config to include the new max_chain_len_for_announces_response setting and initialized it with the default value.
• ethexe/network/src/db_sync/responses.rs
  • Removed the local MAX_CHAIN_LEN_FOR_ANNOUNCES_RESPONSE constant.
  • Updated the OngoingResponses struct to receive max_chain_len_for_announces_response from its configuration.
  • Modified the process_announce_request function and related error types to use the configurable value.
  • Updated test cases to pass the new parameter.
• ethexe/network/src/lib.rs
  • Defined DEFAULT_MAX_CHAIN_LEN_FOR_ANNOUNCES_RESPONSE as a public constant.
  • Added max_chain_len_for_announces_response to NetworkConfig and BehaviourConfig.
  • Ensured the new configuration is passed down to the db_sync::Behaviour initialization.

Activity

• No human activity has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a new CLI parameter, --max-chain-len-for-announces-response, to make the maximum chain length for announce responses configurable. Previously, this was a hardcoded value. The new parameter is correctly plumbed from the CLI configuration down to the networking layer where it's enforced. The default value is maintained for backward compatibility. All related logic, including error messages and tests, has been updated to support this new configuration. The implementation is correct and robust.