feat(objectstore): enable objectstore auth if key is configured#535
Open
matt-codecov wants to merge 1 commit intomainfrom
Open
feat(objectstore): enable objectstore auth if key is configured#535matt-codecov wants to merge 1 commit intomainfrom
matt-codecov wants to merge 1 commit intomainfrom
Conversation
NicoHinderling
approved these changes
Jan 9, 2026
Contributor
NicoHinderling
left a comment
NicoHinderling
left a comment
There was a problem hiding this comment.
lgtm but worth having @rbro112 take a look as well
matt-codecov
force-pushed
the
matth/objectstore-enable-auth
branch
from
422a71f to
20fea25
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Contributor
Sentry Build Distribution
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
matt-codecov
force-pushed
the
matth/objectstore-enable-auth
branch
from
20fea25 to
b84a05b
Compare
matt-codecov
force-pushed
the
matth/objectstore-enable-auth
branch
2 times, most recently
from
e4ca0f7 to
1e49857
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
matt-codecov
force-pushed
the
matth/objectstore-enable-auth
branch
from
1e49857 to
73f721b
Compare
Author
|
i have incorporated some of the AI suggestions and i believe i've fixed the type checking |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ObjectstoreConfigdataclass to config which can configure Objectstore signing key/token creation optionssomething to note: in INF-844 our secrets were provisioned with GCP Secret Manager. @rgibert says for now we have to mount them as files until secret syncing in the GCP SM CSI driver is GA, so that's what this PR does.
working with @rgibert to get these into launchpad's config. https://github.com/getsentry/ops/pull/18653 mounts the signing key as a file, next up i need to figure out where to inject these config values