feat(consola): Enhance Consola integration to extract first-param object as searchable attributes#19534
feat(consola): Enhance Consola integration to extract first-param object as searchable attributes#19534
Conversation
s1gr1d
changed the title
s1gr1d
force-pushed
the
sig/consola-obj-keys
branch
from
c71c835 to
fcfd91c
Compare
| /** | ||
| * Extracts structured attributes from console arguments. If the first argument is a plain object, its properties are extracted as attributes. | ||
| */ | ||
| function defaultExtractAttributes( |
There was a problem hiding this comment.
This is a function that could be theoretically added by users (as a future feature). That's why this function is extra from the processExtractedAttributes. In theory, it could just be one function.
size-limit report 📦
|
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| /** | ||
| * Result of extracting structured attributes from console arguments. | ||
| */ | ||
| export interface ExtractAttributesResult { |
There was a problem hiding this comment.
l: I would not export this as long as the functions stays internal.
s1gr1d
force-pushed
the
sig/consola-obj-keys
branch
from
fcfd91c to
282b963
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| return { | ||
| message: message, | ||
| attributes: { | ||
| ...normalize(attributes, normalizeDepth, normalizeMaxBreadth), |
There was a problem hiding this comment.
Object-first attributes normalized one level shallower than rest
Medium Severity
normalize(attributes, normalizeDepth, normalizeMaxBreadth) normalizes the entire extracted attributes object as one entity, consuming one depth level for the container. This means each attribute value effectively gets normalizeDepth - 1 levels. In contrast, rest attributes (line 252–254) are normalized per-value with the full normalizeDepth. With the default depth of 3, object-first attribute values get only 2 effective levels — a silent 33% reduction that causes unexpected data truncation for moderately nested objects.
Triggered by project rule: PR Review Guidelines for Cursor Bot
2 participants
Aligns the Consola integration so object-first logs are structured and fallback logs get template + parameters.
Universal principle
Consola-specific behavior
consola.log({ message: "x", userId, action })Consola passesargs: ["x"]and spreads the rest on the log object. We detect this (single string in args + extra keys on logObj) and treat it as one logical object: message =args[0], attributes = extra keys.consola.log.raw({ message: "raw-hello" })produces attributes from the object and an empty message.sentry.message.parameter.*).Example
Console String substitutions are not added as a template attribute because parsing is too complicated on the client-side (see here: #17703)
Closes #18593