footer: remove trailing slashes to prevent 404s#31
Open
ritorhymes wants to merge 1 commit intogitgitgadget:mainfrom
Open
footer: remove trailing slashes to prevent 404s#31ritorhymes wants to merge 1 commit intogitgitgadget:mainfrom
ritorhymes wants to merge 1 commit intogitgitgadget:mainfrom
Conversation
trailing slashes result in 404 for GitHub Pages when an extensionless path is used with uglyURLs enabled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found an edge case: on GitHub Pages, with
uglyURLsenabled, extensionless paths with trailing slashes return404.Footer links currently include trailing slashes, so they are 404ing.
This change removes trailing slashes from footer links so they resolve correctly.
Path behavior:
/architecture.html = ✅
/architecture = ✅
/architecture/ = ❌