Closed
Conversation
Since libgit2's CMakeLists.txt already calls cmake_minimum_required(VERSION 3.5.1) as its very first statement, the variable was always redundant. Removing it eliminates the warning. This is the causing warning: CMake suite maintained and supported by Kitware (kitware.com/cmake). CMake Warning (dev) at CMakeLists.txt:14 (PROJECT): cmake_minimum_required() should be called prior to this top-level project() call. Line 690 in https://github.com/gitx/gitx/actions/runs/22541819447/job/65298081457
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since libgit2's CMakeLists.txt already calls cmake_minimum_required(VERSION 3.5.1) as its very first statement, the variable was always redundant. Removing it eliminates the warning.
This is the causing warning:
CMake suite maintained and supported by Kitware (kitware.com/cmake). CMake Warning (dev) at CMakeLists.txt:14 (PROJECT): cmake_minimum_required() should be called prior to this top-level project() call.
Line 690 in https://github.com/gitx/gitx/actions/runs/22541819447/job/65298081457