Open
Conversation
Contributor
Author
|
Marking this ready for review as it now has tests and I think its enough to start adding Transfer v2 support to going forwards. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
TransferClientV2to experimental, adds its supporting classes, and labels existing v2 support in theTransferClientas Beta as proposed here.Most of the code in this PR is things for the existing
TransferClientthat were copied and then slightly modified to work with Transfer v2. Things that are completely new:TransferClientV2.list_stream_access_pointsSome things that aren't included here but would be nice to have at some point:
dict.GlobusHTTPResponsethat are available if the response looks like a JSON:API responseI also found some issues with the existing tunnels support in the
TransferClientwhile copying things over toTransferClientV2, most notably the iteration onlist_tunnelswas looking for a v1 "DATA" key. I've included fixes for now, but I'm a bit worried about supporting those going forwards. We likely will make more changes and fixesTransferClientV2side that might not make it toTransferClient, so maybe we should deprecate those completely rather than leaving them there with a "careful this is Beta" comment?