Skip to content

Add GEO_AREA support to gooddata-dbt#1383

Merged
hkad98 merged 2 commits intogooddata:masterfrom
hkad98:jkd/geo
Mar 3, 2026
Merged

Add GEO_AREA support to gooddata-dbt#1383
hkad98 merged 2 commits intogooddata:masterfrom
hkad98:jkd/geo

Conversation

@hkad98
Copy link
Contributor

@hkad98 hkad98 commented Mar 3, 2026

GEO_AREA support was missing in gooddata-dbt.

hkad98 added 2 commits March 3, 2026 16:29
Convert Optional[X] to `X | None`.

Also, remove UP038 rule – there was a warning about removal.

JIRA: TRIVIAL
risk: low
GEO_AREA label was missing in gooddata-dbt and needs to be added.

JIRA: TRIVIAL
risk: low
@hkad98 hkad98 requested review from jaceksan, lupko and pcerny as code owners March 3, 2026 15:33
@codecov
Copy link

codecov bot commented Mar 3, 2026

Codecov Report

❌ Patch coverage is 90.24390% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.67%. Comparing base (a19bac3) to head (3e9d0ac).

Files with missing lines Patch % Lines
...kages/gooddata-dbt/src/gooddata_dbt/dbt/metrics.py 0.00% 6 Missing ⚠️
...s/gooddata-dbt/src/gooddata_dbt/gooddata/config.py 0.00% 3 Missing ⚠️
...kages/gooddata-dbt/src/gooddata_dbt/sdk_wrapper.py 0.00% 2 Missing ⚠️
...ta-flight-server/src/gooddata_flight_server/cli.py 0.00% 2 Missing ⚠️
..._flight_server/server/flight_rpc/server_methods.py 0.00% 1 Missing ⚠️
...server/src/gooddata_flight_server/utils/logging.py 75.00% 1 Missing ⚠️
...ages/gooddata-pandas/src/gooddata_pandas/series.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1383      +/-   ##
==========================================
+ Coverage   77.55%   77.67%   +0.11%     
==========================================
  Files         224      224              
  Lines       14432    14424       -8     
==========================================
+ Hits        11193    11204      +11     
+ Misses       3239     3220      -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hkad98 hkad98 enabled auto-merge March 3, 2026 15:39
@hkad98 hkad98 merged commit 51389a4 into gooddata:master Mar 3, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants