fix(litellm): preserve thought_signature in tool call round-trip#4662
fix(litellm): preserve thought_signature in tool call round-trip#4662pandego wants to merge 2 commits intogoogle:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue where Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly implements the preservation of thought_signature during the round-trip conversion of tool calls for LiteLLM. The new encoding and decoding functions are well-defined, and their integration into _content_to_message_param and _message_to_generate_content_response is appropriate. The added unit tests provide good coverage for the new functionality. I have one suggestion to improve debuggability in an error case.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
Testing Plan
Unit Tests:
Passed locally:
uv run pytest tests/unittests/models/test_litellm.py -k "thought_signature or message_to_generate_content_response_tool_call"Checklist
Additional context
This patch keeps LiteLLM's tool-call id encoding contract intact for Gemini thinking models by:
Part.thought_signature, andPart.thought_signaturewhen building outgoing LiteLLM tool calls.It also adds focused unit tests for both decode and encode paths.