Skip to content

Fix issue 4680#4682

Open
DrewAfromsky wants to merge 1 commit intogoogle:mainfrom
DrewAfromsky:fix/test-failures-unittest.sh
Open

Fix issue 4680#4682
DrewAfromsky wants to merge 1 commit intogoogle:mainfrom
DrewAfromsky:fix/test-failures-unittest.sh

Conversation

@DrewAfromsky
Copy link

Link to Issue or Description of Change

1. Link to an existing issue (if applicable):

Testing Plan

  • Re-ran ./scripts/unittests.sh without any errors and all tests (including pytest) pass in all environments.
  • Successfully completed steps 5 (./scripts/unittests.sh) - step 8 in CONTRIBUTING.md.

Manual End-to-End (E2E) Tests:

Please provide instructions on how to manually test your changes, including any
necessary setup or configuration. Please provide logs or screenshots to help
reviewers better understand the fix.

  • ./scripts/unittests.sh runs successfully end-to-end without any test failures.

Checklist

  • I have read the CONTRIBUTING.md document.
  • I have performed a self-review of my own code.
  • [N/A] I have commented my code, particularly in hard-to-understand areas.
  • [N/A] I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have manually tested my changes end-to-end.
  • Any dependent changes have been merged and published in downstream modules.

Additional context

adk-web-what-is-weather-Event adk-web-what-is-weather-Event2 adk-web-trace adk-web-what-time-is-it adk-web-what-can-you-do adk-web-startup

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where ModelResponse objects within litellm unit tests were not consistently initialized with usage metadata. By adding the usage dictionary to these test cases, the change ensures that the tests accurately reflect the expected structure of model responses, thereby fixing a reported bug and enhancing the reliability of the test suite.

Highlights

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • tests/unittests/models/test_litellm.py
    • Added usage dictionary to ModelResponse instances in test_to_litellm_role test cases.
    • Ensured prompt_tokens, completion_tokens, and total_tokens are initialized to 0 within the new usage dictionaries.
Activity
  • The author re-ran ./scripts/unittests.sh with all tests passing in all environments.
  • Manual end-to-end tests were successfully completed, confirming the fix.
  • The author completed a self-review of the code and confirmed adherence to the contributing guidelines.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@adk-bot adk-bot added the models [Component] Issues related to model support label Mar 2, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates test data in tests/unittests/models/test_litellm.py by adding a usage dictionary to ModelResponse instances in several test cases for the test_model_response_to_chunk function. These changes appear to be aimed at ensuring the tests correctly handle responses that include usage metadata, aligning the test inputs with the expected outputs.

@GWeale GWeale self-requested a review March 2, 2026 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

models [Component] Issues related to model support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] unittests.sh Script Failure to Execute Beyond Python 3.10 Environment - Blocked by Test Case Failures in test_litellm.py

2 participants