Add test confirming that login works without contact obj URI#2983
Add test confirming that login works without contact obj URI#2983CydeWeys wants to merge 1 commit intogoogle:masterfrom
Conversation
This is a follow-up to PR google#2954.
|
nit: use a more expressive name for this file, like "login_valid_without_contact_objuri.xml" Code quote: login_valid |
jicelhay
left a comment
There was a problem hiding this comment.
@jicelhay reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on CydeWeys).
CydeWeys
left a comment
There was a problem hiding this comment.
@CydeWeys made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on jicelhay).
core/src/test/java/google/registry/flows/session/LoginFlowTestCase.java line 152 at r1 (raw file):
Previously, jicelhay (Juan Celhay) wrote…
nit: use a more expressive name for this file, like "login_valid_without_contact_objuri.xml"
That would necessitate another renaming of the file shortly down the road, as we are removing the contact Obj URI handling entirely following the completion of the migration on March 31st. Past that point, there will be no contact Obj URIs anywhere in the codebase, and it won't really make sense to refer to the main valid login EPP XML test file using the name of one of many things that happens to be absent from it.
jicelhay
left a comment
There was a problem hiding this comment.
@jicelhay reviewed 1 file and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on CydeWeys).
This is a follow-up to PR #2954.
This change is