Skip to content

Add test confirming that login works without contact obj URI#2983

Open
CydeWeys wants to merge 1 commit intogoogle:masterfrom
CydeWeys:contact-obj-test
Open

Add test confirming that login works without contact obj URI#2983
CydeWeys wants to merge 1 commit intogoogle:masterfrom
CydeWeys:contact-obj-test

Conversation

@CydeWeys
Copy link
Member

@CydeWeys CydeWeys commented Mar 17, 2026

This is a follow-up to PR #2954.


This change is Reviewable

@CydeWeys CydeWeys requested a review from jicelhay March 17, 2026 17:45
@CydeWeys CydeWeys enabled auto-merge March 17, 2026 17:46
@jicelhay
Copy link
Collaborator

core/src/test/java/google/registry/flows/session/LoginFlowTestCase.java line 152 at r1 (raw file):

            .setStatusMap(ImmutableSortedMap.of(START_OF_TIME, FeatureStatus.INACTIVE))
            .build());
    doSuccessfulTest("login_valid.xml");

nit: use a more expressive name for this file, like "login_valid_without_contact_objuri.xml"

Code quote:

login_valid

Copy link
Collaborator

@jicelhay jicelhay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jicelhay reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on CydeWeys).

Copy link
Member Author

@CydeWeys CydeWeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CydeWeys made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on jicelhay).


core/src/test/java/google/registry/flows/session/LoginFlowTestCase.java line 152 at r1 (raw file):

Previously, jicelhay (Juan Celhay) wrote…

nit: use a more expressive name for this file, like "login_valid_without_contact_objuri.xml"

That would necessitate another renaming of the file shortly down the road, as we are removing the contact Obj URI handling entirely following the completion of the migration on March 31st. Past that point, there will be no contact Obj URIs anywhere in the codebase, and it won't really make sense to refer to the main valid login EPP XML test file using the name of one of many things that happens to be absent from it.

Copy link
Collaborator

@jicelhay jicelhay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jicelhay reviewed 1 file and resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on CydeWeys).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants