Skip to content

chore: librarian generate pull request: 20260304T223823Z#16025

Merged
codyoss merged 1 commit intomainfrom
librarian-20260304T223823Z
Mar 5, 2026
Merged

chore: librarian generate pull request: 20260304T223823Z#16025
codyoss merged 1 commit intomainfrom
librarian-20260304T223823Z

Conversation

@parthea
Copy link
Contributor

@parthea parthea commented Mar 4, 2026

PR created by the Librarian CLI to generate Cloud Client Libraries code from protos.

BEGIN_COMMIT

BEGIN_NESTED_COMMIT
feat: expose the variable definition in the Cloud Firestore API

PiperOrigin-RevId: 877535984
Library-IDs: google-cloud-firestore
Source-link: googleapis/googleapis@1ccd68a0
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
chore: Firestore.executePipeline to not retry on RESOURCE_EXHAUSTED

PiperOrigin-RevId: 877535984
Library-IDs: google-cloud-firestore
Source-link: googleapis/googleapis@1ccd68a0
END_NESTED_COMMIT

END_COMMIT

This pull request is generated with proto changes between
googleapis/googleapis@d420134a
(exclusive) and
googleapis/googleapis@1ccd68a0
(inclusive).

Librarian Version: v0.7.0
Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:160860d189ff1c2f7515638478823712fa5b243e27ccc33a2728669fa1e2ed0c

@parthea parthea requested review from a team as code owners March 4, 2026 22:39
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically generated by the Librarian CLI, updates the Cloud Firestore client library. It introduces a new field for variable references within the API and adjusts the retry behavior for executePipeline operations by excluding RESOURCE_EXHAUSTED errors. Additionally, several internal package references and documentation configurations have been streamlined to align with the google-cloud-firestore package name.

Highlights

  • API Enhancement: A new variable_reference_value field has been exposed in the Cloud Firestore API, allowing for pointers to variables defined elsewhere in a pipeline.
  • Retry Logic Adjustment: The retry behavior for Firestore's executePipeline operations has been updated to no longer retry on RESOURCE_EXHAUSTED errors.
  • Package Renaming and Configuration Update: Various internal configuration, documentation, and build files have been updated to reflect a package name change from google-cloud-firestore-admin to google-cloud-firestore.
Changelog
  • .librarian/state.yaml
    • Updated the last_generated_commit for the google-cloud-firestore library.
  • packages/google-cloud-firestore/.coveragerc
    • Corrected paths for __init__.py and gapic_version.py from firestore_admin to firestore in the omit list.
  • packages/google-cloud-firestore/docs/conf.py
    • Renamed project, description, and various documentation output filenames from google-cloud-firestore-admin to google-cloud-firestore.
  • packages/google-cloud-firestore/google/cloud/firestore_v1/services/firestore/transports/base.py
    • Removed core_exceptions.ResourceExhausted from the retry predicate for several methods.
  • packages/google-cloud-firestore/google/cloud/firestore_v1/services/firestore/transports/grpc_asyncio.py
    • Removed core_exceptions.ResourceExhausted from the retry predicate for several asynchronous methods.
  • packages/google-cloud-firestore/google/cloud/firestore_v1/types/document.py
    • Added a new variable_reference_value field to the Value class, allowing string pointers to pipeline variables.
  • packages/google-cloud-firestore/noxfile.py
    • Updated the PACKAGE_NAME variable from google-cloud-firestore-admin to google-cloud-firestore.
  • packages/google-cloud-firestore/setup.py
    • Changed the package name, description, and url from google-cloud-firestore-admin to google-cloud-firestore, and updated the path for gapic_version.py.
Activity
  • This pull request was automatically generated by the Librarian CLI.
  • It incorporates proto changes from googleapis/googleapis@d420134a to googleapis/googleapis@1ccd68a0.
  • The changes include exposing variable definitions in the Cloud Firestore API.
  • The changes also include modifying Firestore.executePipeline to not retry on RESOURCE_EXHAUSTED.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the google-cloud-firestore library, incorporating two main changes. Firstly, it exposes a new variable_reference_value field within the Cloud Firestore API, enhancing the flexibility of value definitions. Secondly, the retry logic for Firestore.executePipeline has been adjusted to no longer retry on RESOURCE_EXHAUSTED errors. Additionally, various configuration and documentation files have been updated to reflect the package name change from google-cloud-firestore-admin to google-cloud-firestore. The changes are consistent with the stated objectives and appear to be correctly implemented.

@codyoss codyoss merged commit 4937235 into main Mar 5, 2026
27 checks passed
@codyoss codyoss deleted the librarian-20260304T223823Z branch March 5, 2026 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants