Conversation
Member
|
Not sure I fully understand how our cache is working right now. Will lean on Yang to merge |
Jack-Khuu
changed the title
yangw-dev
reviewed
Mar 6, 2026
Collaborator
|
i'm fine with the ui changes to introduce graceperiod for loading, but i don't think the full response cache works, |
Jack-Khuu
changed the title
Collaborator
Author
|
Removed fast-cache |
yangw-dev
approved these changes
Mar 6, 2026
Jack-Khuu
added a commit
that referenced
this pull request
Mar 6, 2026
msaroufim
pushed a commit
that referenced
this pull request
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even with the initial loading check (#212), the cache return time is still triggering a loading screen. This PR adds a grace period (200ms) for the cache to return, before the loading screen tries render
Screen.Recording.2026-03-05.at.7.12.03.PM.mov