Refactor diff component and improve LiveView integration#111
Open
kyleboe wants to merge 7 commits intohexpm:mainfrom
Open
Refactor diff component and improve LiveView integration#111kyleboe wants to merge 7 commits intohexpm:mainfrom
kyleboe wants to merge 7 commits intohexpm:mainfrom
Conversation
Author
|
As an aside, none of the other event handlers in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors how file diffs are shown and hidden in the UI, removing the broken JavaScript and using LiveView JS commands to simplify the code. It removes the old "collapse/reveal" icons and logic in favor of a single toggle icon & modern CSS.