JSON heuristic: don't consider strings as primitive#340
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refines the JSON collapse/expand heuristic by treating strings as non-primitive values, causing arrays and objects containing strings to be expanded by default rather than collapsed. This improves the default viewing experience for string-containing data structures.
Key Changes:
- Modified
isPrimitive()to exclude strings from primitive classification - Updated test descriptions and cases to reflect the new string handling behavior
- Minor CI workflow improvement to restrict push triggers to master branch
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/components/Json/helpers.ts | Excludes strings from primitive classification in the isPrimitive() function |
| src/components/Json/Json.test.tsx | Updates tests to verify new string-handling behavior and adjusts test descriptions |
| .github/workflows/ci.yml | Restricts push-triggered CI runs to master branch and removes trailing whitespace |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
035b017 to
611ee10
Compare
611ee10 to
0c49a20
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WDYT @platypii? It's a simple change, but I think it works better.
Screencast.From.2025-10-17.11-07-50.mp4
The only objection might be that an array of very small strings, eg:
['a', 'b']would be better collapsed than expanded by default. But it would require a bit more complexity in the heuristic, and I'm not sure we would see this kind of data too often