Check whether the "type" key in error responses is present#411
Merged
icing merged 1 commit intoicing:masterfrom Mar 13, 2026
Merged
Check whether the "type" key in error responses is present#411icing merged 1 commit intoicing:masterfrom
icing merged 1 commit intoicing:masterfrom
Conversation
icing
approved these changes
Mar 13, 2026
Owner
|
Seems sensible to not crash on broken servers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mod_md crashes when processing a JSON error response that does not have a "type" key.