Add launch action to VM installer completion screen#658
Open
MrRooni wants to merge 1 commit intoinsidegui:mainfrom
Open
Add launch action to VM installer completion screen#658MrRooni wants to merge 1 commit intoinsidegui:mainfrom
MrRooni wants to merge 1 commit intoinsidegui:mainfrom
Conversation
Added a dedicated installer completion view with a primary launch action Replace the inline done-state progress UI with InstallProgressDoneView and add a "Let’s Go!" button that launches the newly created VM and dismisses the installer. Use a hidden default-action button to preserve the Return key shortcut without letting macOS override the visible button’s custom text color.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🦾 Reason to Be
This MR updates the installer completion screen so finishing a VM setup leaves the user with an actionable next step. The
.donestep now shows a dedicated completion view with a primaryLet’s Go!action that launches the newly created virtual machine and dismisses the installer window.It also wires
VirtualMachineSessionUIManagerinto the installer launch path and wizard previews so the completion screen has the session-launch dependency it needs.🤔 Thought Process
Built with help from Codex.
The completion state originally used a generic success progress view, which was fine for status display but not for the new launch action and layout requirements. I split the
.donestate into its ownInstallProgressDoneViewso the completion UI could be structured independently without complicating the main progress display switch.From there, I added a visible
Let’s Go!button for the primary action and kept the Return key behavior by using a hidden default-action button. That avoids macOS overriding the visible button’s styling when.keyboardShortcut(.defaultAction)is applied directly.I also removed the default-action shortcut from the toolbar
Donebutton so Return triggers launch instead of close, and updated the installer launch wiring so the new completion view can accessVirtualMachineSessionUIManagerthrough the environment.📋 How To Test
.donescreen shows the dedicated completion UI with the success icon, finished message, andLet’s Go!button.Let’s Go!and verify the new VM launches and the installer window closes.Donebutton and verify it closes the installer without launching the VM.🐛 Possible Impacts
The main risk area is installer window/environment wiring. The completion screen now depends on
VirtualMachineSessionUIManagerbeing injected anywhereVMInstallationWizardis presented, so any code path that opens the installer without that environment object could break or fail to launch the VM from the done state.There is also some behavioral risk around keyboard handling on the completion screen, since Return is now intentionally routed to launch rather than to the toolbar
Doneaction.