Apology: Previous Version Was Not Properly Verified Before Pull Request

[rapeeza1598]

I apologize for the previous version. I did not verify the changes thoroughly before submitting the pull request, which caused issues. I have now reviewed and fixed the problem in this update. Thank you for your patience and for reviewing the correction.

[jhd3197]

Hi @rapeeza1598, thanks for the contribution and for the uninstall script — that's a great addition!

Before I can merge this, I need to understand a few things about the install.sh changes. Several critical blocks were removed and I'd like to know if that was intentional or accidental:

1. Nginx site configuration removed

The original script installs the ServerKit nginx site config (sites-available/serverkit.conf), symlinks it to sites-enabled/, removes the default site, and ensures the include directive exists in nginx.conf. Your version replaces all of that with just apt install nginx && systemctl start. Without the site config, nginx serves its default page and the panel is unreachable.

Can you explain why this was removed? Was this causing issues on your setup?

2. SSL certificate generation removed

The self-signed SSL cert block (openssl req -x509 ...) is gone. This means the panel would only serve over HTTP — credentials sent in cleartext.

Was SSL causing problems for you, or was this an oversight?

3. SELinux boolean for Fedora removed

The setsebool -P httpd_can_network_connect 1 call is needed on Fedora for nginx to proxy to the backend. Without it, Fedora installs get 502 errors.

Are you testing on Fedora? This is required for that platform.

4. check_ram() and setup_swap() defined but never called

These are the main feature of your PR (low RAM safe mode), but they're never invoked in the script body. SAFE_MODE stays false and the --no-cache-dir pip optimization is unreachable.

Was this still a work in progress?

5. CORS_ORIGINS removed from .env template

The original .env included CORS_ORIGINS=http://localhost,https://localhost. Your version drops it.

6. Indentation stripped

All function bodies and control flow lost their indentation — everything is flush-left. This makes the script much harder to maintain.

---

I'd love to keep the Python version detection and the uninstall.sh — those are solid additions. But I need to understand the reasoning behind the removals before merging. Could you provide some context about your use case and environment?

Thanks!

[rapeeza1598]

I've pushed an update addressing all the points mentioned in the review.

Changes include restoring the nginx site configuration, SSL self-signed certificate generation, the Fedora SELinux boolean, invoking the check_ram() and setup_swap() functions, restoring CORS_ORIGINS, and fixing the script indentation/formatting.

I also added a small safety check in the uninstaller to avoid errors if Docker or the install directory does not exist.

Could you please take another look when you have a moment?
Thanks!