fix: allow replays list/download for deleted browser sessions#135
Merged
fix: allow replays list/download for deleted browser sessions#135
Conversation
The CLI was calling GET /browsers/{id} before listing or downloading
replays, which returns 404 for deleted sessions. Skip that lookup
and pass the session ID directly to the replay endpoints, which
already work for deleted sessions.
Fixes KERNEL-1098
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CLI was calling GET /browsers/{id} before listing or downloading replays, which returns 404 for deleted sessions. Skip that lookup and pass the session ID directly to the replay endpoints, which already work for deleted sessions.
Fixes KERNEL-1098
Note
Low Risk
Low risk: small CLI change to remove a preflight
GET /browsers/{id}call; main risk is thatIdentifiermust be a session ID for replay endpoints and error messaging may change slightly.Overview
Fixes
browsers replays listandbrowsers replays downloadto skip the browser lookup and call the replay endpoints directly with the provided identifier, allowing replay operations to work even when the browser session has been deleted.Written by Cursor Bugbot for commit 30546b0. This will update automatically on new commits. Configure here.