Skip to content

[kernel-838] add fix for cli file upload#182

Open
archandatta wants to merge 1 commit intomainfrom
archand/kernel-838/fix-file-upload
Open

[kernel-838] add fix for cli file upload#182
archandatta wants to merge 1 commit intomainfrom
archand/kernel-838/fix-file-upload

Conversation

@archandatta
Copy link
Contributor

@archandatta archandatta commented Mar 18, 2026

Test:

  # NEW: files.file / files.dest_path (no-index comma format)
  curl -s -w " HTTP %{http_code}" -X POST "$BASE/fs/upload" \
    -F "files.file=@/tmp/curl_test_payload.txt" \
    -F "files.dest_path=/tmp/test_comma_format.txt"

  # Verify it was written
  curl -s -w " HTTP %{http_code}" "$BASE/fs/read_file?path=/tmp/test_comma_format.txt"

Note

Medium Risk
Changes multipart field parsing for the filesystem upload endpoint, which could affect how file uploads are interpreted and written to disk if clients send ambiguous field names.

Overview
UploadFiles now accepts a no-index multipart “comma” array format (files.file and files.dest_path), treating it as index 0 in addition to the existing indexed field encodings.

Adds a focused regression test (TestUploadFilesCommaFormat) to verify the new field naming convention successfully uploads and writes the file to the requested destination.

Written by Cursor Bugbot for commit 58b11cf. This will update automatically on new commits. Configure here.

@archandatta archandatta force-pushed the archand/kernel-838/fix-file-upload branch from 595d9ea to 58b11cf Compare March 18, 2026 12:51
@archandatta archandatta requested a review from ehfeng March 18, 2026 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant