Skip to content

feat: react mode baseline type checking.#15

Merged
knightedcodemonkey merged 4 commits intomainfrom
bananas
Mar 18, 2026
Merged

feat: react mode baseline type checking.#15
knightedcodemonkey merged 4 commits intomainfrom
bananas

Conversation

@knightedcodemonkey
Copy link
Owner

No description provided.

Copilot AI review requested due to automatic review settings March 18, 2026 23:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a React-mode-aware TypeScript diagnostics pipeline that can hydrate @types/react/@types/react-dom (and transitive deps) from CDN into the in-browser virtual FS, while also updating the JSX transform runtime integration and adding regression coverage + documentation.

Changes:

  • Implement lazy React type graph hydration + virtual node_modules module resolution for browser TypeScript diagnostics.
  • Rename/upgrade JSX transpile integration to jsxTransform / transformJsxSource, including runtime import handling.
  • Add Playwright coverage and docs describing the in-browser typechecking architecture.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/modules/type-diagnostics.js Adds React-mode type package hydration, reference parsing, and a richer TS host/module resolution bridge.
src/modules/render-runtime.js Switches to transformJsxSource and adds runtime import stripping + React import binding preamble.
src/modules/defaults.js Updates the default React example to use proper React imports and typed MouseEvent.
src/modules/cdn.js Adds jsxTransform spec and introduces getTypePackageFileUrls for fetching @types/* files.
src/bootstrap.js Updates modulepreload list to preload jsxTransform instead of jsxTranspile.
src/app.js Wires getTypePackageFileUrls + render mode into the type diagnostics controller.
playwright/app.spec.ts Adds an e2e regression ensuring React-mode type hydration avoids malformed URL fetches.
docs/type-checking.md New documentation describing browser typechecking + React-mode type hydration approach.
docs/next-steps.md Adds a follow-up checklist item describing the preprocessor-first reference parsing hardening effort.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@knightedcodemonkey knightedcodemonkey merged commit 9706f33 into main Mar 18, 2026
1 check passed
@knightedcodemonkey knightedcodemonkey deleted the bananas branch March 18, 2026 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants