Add Docker support for easier deployments#59
Conversation
|
@alfonsrv can you please apply DCO and rebase on main ? |
alfonsrv
force-pushed
the
main
branch
4 times, most recently
from
7e25c11 to
dce35ab
Compare
|
Hey @simo5, can you check if it's okay now? I also uppercased |
Author: alfonsrv <alfonsrv@protonmail.com> Developer Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me. (c) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. Signed-off-by: github/alfonsrv <alfonsrv@protonmail.com> Signed-off-by: alfons <alfonsrv@protonmail.com>
kdcproxy/parse_pyasn1.py
Outdated
| realm = str(realm, "utf-8") | ||
| except TypeError: # Python 2.x | ||
| realm = str(realm) | ||
| realm = realm.upper() |
There was a problem hiding this comment.
I now see your comment, realm is definitely a case sensitive name, even though Windows plays fast and lose with it. If you need a matching logic that is case -insensitive please do that. This change would break KDCs based on MIT kerberos or other more standard compliant Krb5 implementations.
docker/docker-compose.yml
Outdated
| - "443:443" | ||
| environment: | ||
| - KDCPROXY_CONFIG=/config/kdcproxy.conf | ||
| - SERVER_NAME=${SERVER_NAME:-selfsign.rausys.de} |
There was a problem hiding this comment.
his looks custom to your deployment or something, I am not sure we should have this file at all in the repository, sounds like configuration each deployment should deal with on their own.
…ment to the WSGIDaemonProcess directive to ensure mod_wsgi includes the relevant Python site-packages directory / doesn't use the default-assumed one managed via apt.
2 participants
No description provided.