Skip to content

fix: Make defaultValue optional with a disabled default#1144

Merged
jsonbailey merged 6 commits intomainfrom
jb/aic-1628/make-defaults-optional
Mar 5, 2026
Merged

fix: Make defaultValue optional with a disabled default#1144
jsonbailey merged 6 commits intomainfrom
jb/aic-1628/make-defaults-optional

Conversation

@jsonbailey
Copy link
Contributor

@jsonbailey jsonbailey commented Mar 3, 2026

Note

Medium Risk
Public SDK API/type changes (optional parameter + new defaulting behavior) could impact consumers’ TypeScript expectations and runtime defaults, though the behavior is straightforward and covered by new tests.

Overview
Updates the Server AI SDK API so defaultValue becomes optional across completionConfig, agentConfig, judgeConfig, createChat, createJudge, and related deprecated/multi-agent helpers; when omitted or null, the SDK now evaluates flags using a shared { enabled: false } disabled fallback.

Adds tests covering the no-default behavior and updates docs/examples to demonstrate omitting defaultValue (or providing one for resiliency) and clarifies the new semantics in README.md and interface/type docs.

Written by Cursor Bugbot for commit cb67dae. This will update automatically on new commits. Configure here.

@jsonbailey jsonbailey requested a review from a team as a code owner March 3, 2026 16:25
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2026

@launchdarkly/js-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 25566 bytes
Compressed size limit: 26000
Uncompressed size: 125383 bytes

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2026

@launchdarkly/js-client-sdk size report
This is the brotli compressed size of the ESM build.
Compressed size: 23845 bytes
Compressed size limit: 25000
Uncompressed size: 82750 bytes

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2026

@launchdarkly/js-client-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 20569 bytes
Compressed size limit: 24000
Uncompressed size: 107197 bytes

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2026

@launchdarkly/browser size report
This is the brotli compressed size of the ESM build.
Compressed size: 171694 bytes
Compressed size limit: 200000
Uncompressed size: 799867 bytes

joker23
joker23 approved these changes Mar 4, 2026
@jsonbailey jsonbailey force-pushed the jb/aic-1628/make-defaults-optional branch from eb39e2c to 58dc9bf Compare March 5, 2026 17:11
@jsonbailey jsonbailey merged commit e46769b into main Mar 5, 2026
41 checks passed
@jsonbailey jsonbailey deleted the jb/aic-1628/make-defaults-optional branch March 5, 2026 19:23
@github-actions github-actions bot mentioned this pull request Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants