fix: Make defaultValue optional with a disabled default#1144
Merged
jsonbailey merged 6 commits intomainfrom Mar 5, 2026
Merged
fix: Make defaultValue optional with a disabled default#1144jsonbailey merged 6 commits intomainfrom
jsonbailey merged 6 commits intomainfrom
Conversation
Contributor
|
@launchdarkly/js-sdk-common size report |
Contributor
|
@launchdarkly/js-client-sdk size report |
Contributor
|
@launchdarkly/js-client-sdk-common size report |
Contributor
|
@launchdarkly/browser size report |
joker23
reviewed
Mar 3, 2026
joker23
reviewed
Mar 3, 2026
joker23
reviewed
Mar 4, 2026
kinyoklion
approved these changes
Mar 4, 2026
eb39e2c to
58dc9bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Public SDK API/type changes (optional parameter + new defaulting behavior) could impact consumers’ TypeScript expectations and runtime defaults, though the behavior is straightforward and covered by new tests.
Overview
Updates the Server AI SDK API so
defaultValuebecomes optional acrosscompletionConfig,agentConfig,judgeConfig,createChat,createJudge, and related deprecated/multi-agent helpers; when omitted or null, the SDK now evaluates flags using a shared{ enabled: false }disabled fallback.Adds tests covering the no-default behavior and updates docs/examples to demonstrate omitting
defaultValue(or providing one for resiliency) and clarifies the new semantics inREADME.mdand interface/type docs.Written by Cursor Bugbot for commit cb67dae. This will update automatically on new commits. Configure here.