Conversation
…` option
- Wrap caller's search criteria in `{ where }` when calling ldkit's
`find()` and `count()`, which previously spread args at the top level
where `take`/`skip` from callers would be silently ignored
- Accept search criteria directly instead of requiring callers to wrap
in `{ where }` — the client handles the ldkit-specific structure
- Export typed `SearchCriteria` instead of using untyped `object`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{ where }when calling ldkit'sfind()andcount()— previously the criteria object was spread at the top level, causing caller-providedtake/skipto be silently overridden{ distribution: { mediaType: ... } }) instead of wrapping in{ where: { ... } }— the client handles the ldkit-specific structure internallySearchCriteriaalias (based on ldkit'sSchemaSearchInterface) instead of accepting untypedobject