fix(dataset-registry-client): work around LDkit count() ignoring $id filter#207
Merged
fix(dataset-registry-client): work around LDkit count() ignoring $id filter#207
Conversation
…filter - When $id is set, use find() directly instead of count() to get accurate totals (LDkit's countQuery() doesn't handle $id) - Return pre-fetched results in the paginator callback for $id queries - Add test for querying a dataset by $id
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LDkit 2.6.0 has a bug where
Lens.count()ignores the$idproperty in search criteria (karelklima/ldkit#169). This causesPaginatorto loop forever when querying by IRI, becausecount()returns the total of all datasets whilefind()correctly returns only the matching one.$idis set, skipcount()and usefind()directly — IRI lookups don't need paginationfind()call$idThe workaround should be removed once LDkit publishes a fix upstream.