fix: improve Name.isMetaprogramming#12767
Open
JovanGerb wants to merge 1 commit intoleanprover:masterfrom
Open
fix: improve Name.isMetaprogramming#12767JovanGerb wants to merge 1 commit intoleanprover:masterfrom
Name.isMetaprogramming#12767JovanGerb wants to merge 1 commit intoleanprover:masterfrom
Conversation
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
Contributor
Author
|
changelog-language |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes sure that identifiers with
MetaorSimprocin their name do not show up in library search results.For example,
Nat.Simproc.eq_add_gtcan currently be suggested by library search, even though it is an implementation detail. Additionally, there are various declarations in mathlib in theMathlib.Metanamespace that we do not want to suggest.