[DO NOT MERGE] fix module system and shake failures#12834
Closed
seanmcl wants to merge 1 commit intoleanprover:masterfrom
Closed
[DO NOT MERGE] fix module system and shake failures#12834seanmcl wants to merge 1 commit intoleanprover:masterfrom
seanmcl wants to merge 1 commit intoleanprover:masterfrom
Conversation
Contributor
Author
|
It turns out Claude is not all knowing. This fix doesn't work when I change imports a bit. Closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a solution Claude came up with to unblock us using the
lake shaketool. It seems there are several bugs in the module system and tool that make it not work for us, e.g.Both have minimal repros. This PR probably isn't the best fix, but works for our project. Perhaps it can assist finding the right solution.