Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a comprehensive refactor of the C++ infrastructure for
async_context. The changes include:libhal‑cmake‑utilforbuild configuration, simplifying library creation and test integration.
BUILD_UNIT_TESTS,BUILD_BENCHMARKS,etc.) with the new
libhalconventions (libhal_project_init,libhal_add_library, etc.).(
-fexceptions,-fno‑rtti) that are no longer required with the newtooling.
compile_commands_clangd_resolver.pyscript andVS Code settings to improve clang‑d diagnostics.
.clang-tidyconfiguration, removing unused checks andadding a header‑filter.
async_context.cppm– added missing[[nodiscard]], suppressedfalse‑positive analyzer checks, and removed an unnecessary
block_by_iocall.
basic_context.test.cpp,basics.test.cpp,etc.) to use
[[maybe_unused]]where appropriate.tests/main.test.cpp) and replaced it withper‑test
main()functions that drive each suite.references to legacy configuration.
The net effect is a cleaner, more maintainable build system that aligns
with the current
libhalecosystem and resolves all clang‑tidycomplaints. This brings the project closer to a stable 1.0 release.