Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes reliance on _CRT_SECURE_NO_WARNINGS in the Windows backend by switching to MSVC “secure CRT” function variants where appropriate, addressing MSVC warning noise reported in #770.
Changes:
- Removed
_CRT_SECURE_NO_WARNINGSdefines from Windows source/header files. - Introduced MSVC-version-gated wrappers to use
swprintf_s/wcsncpy_sinwindows/hid.c. - Updated the Windows HID report reconstructor test to use
sscanf_s(with required buffer-size args) when building with MSVC.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| windows/test/hid_report_reconstructor_test.c | Uses sscanf_s on MSVC (and passes scanset buffer sizes) to avoid CRT “unsafe” warnings. |
| windows/hidapi_descriptor_reconstruct.h | Removes _CRT_SECURE_NO_WARNINGS define block. |
| windows/hid.c | Removes _CRT_SECURE_NO_WARNINGS and uses MSVC secure CRT wrappers for swprintf/wcsncpy. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- use *_s version of swprintf/wcsncpy/sscanf when possible Fixes: #770
be3a8a1 to
3a81d4d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #770