reactor: STORIF-285 - Quota resource metric converted into an enum.#13447
Open
dchyrva-akamai wants to merge 1 commit intolinode:developfrom
Open
reactor: STORIF-285 - Quota resource metric converted into an enum.#13447dchyrva-akamai wants to merge 1 commit intolinode:developfrom
dchyrva-akamai wants to merge 1 commit intolinode:developfrom
Conversation
dchyrva-akamai
force-pushed
the
feature/STORIF-285
branch
4 times, most recently
from
eb52cb3 to
9a313ac
Compare
skulpok-akamai
approved these changes
Mar 5, 2026
| convertedUsage: number; | ||
| } => { | ||
| if (initialResourceMetric === 'byte') { | ||
| if (initialResourceMetric === QuotaResourceMetrics.BYTE) { |
Contributor
There was a problem hiding this comment.
I'm in the "switch-case > if-else" team, but I guess that also works...
dchyrva-akamai
force-pushed
the
feature/STORIF-285
branch
from
9a313ac to
47bd8e6
Compare
dchyrva-akamai
force-pushed
the
feature/STORIF-285
branch
from
47bd8e6 to
8eea0a4
Compare
Collaborator
Cloud Manager UI test results🔺 5 failing tests on test run #8 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/parentChild/account-switching.spec.ts,cypress/e2e/core/objectStorage/object-storage.e2e.spec.ts,cypress/e2e/core/linodes/rebuild-linode.spec.ts" |
|||||||||||||||||||||||||||||
dwiley-akamai
approved these changes
Mar 5, 2026
Contributor
dwiley-akamai
left a comment
dwiley-akamai
left a comment
There was a problem hiding this comment.
Code review ✅
Please add a changeset prior to merging 👌🏾
| @@ -1,3 +1,4 @@ | |||
| import { type Quota, QuotaResourceMetrics } from '@linode/api-v4'; | |||
Contributor
There was a problem hiding this comment.
split the Quota import into its own statement so the linter will sort it to the bottom of the imports
Comment on lines
+1
to
+5
| import { | ||
| type Quota, | ||
| QuotaResourceMetrics, | ||
| type QuotaUsage, | ||
| } from '@linode/api-v4/lib/quotas/types'; |
Contributor
There was a problem hiding this comment.
same here, break out the type imports
Comment on lines
+1
to
+7
| import { | ||
| type ObjectStorageEndpoint, | ||
| type Quota, | ||
| QuotaResourceMetrics, | ||
| type QuotaType, | ||
| type QuotaUsage, | ||
| } from '@linode/api-v4'; |
Contributor
There was a problem hiding this comment.
type import breakouts here too
Comment on lines
+152
to
+172
| import { | ||
| type AccountMaintenance, | ||
| type AlertDefinitionType, | ||
| type AlertSeverityType, | ||
| type AlertStatusType, | ||
| type CloudPulseServiceType, | ||
| type CreateAlertDefinitionPayload, | ||
| type CreateObjectStorageKeyPayload, | ||
| type Dashboard, | ||
| type Database, | ||
| type FirewallStatus, | ||
| type NotificationType, | ||
| type ObjectStorageEndpointTypes, | ||
| QuotaResourceMetrics, | ||
| type SecurityQuestionsPayload, | ||
| type ServiceTypesList, | ||
| type TokenRequest, | ||
| type UpdateImageRegionsPayload, | ||
| type User, | ||
| type VolumeStatus, | ||
| } from '@linode/api-v4'; |
Contributor
There was a problem hiding this comment.
type import breakouts here too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Quota resource metric converted into an enum.
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅