Skip to content

fix: [UIE-10285] - Advanced Config field tooltip error#13465

Open
hana-akamai wants to merge 2 commits intolinode:developfrom
hana-akamai:UIE-10285-advanced-config-field-tooltip-error
Open

fix: [UIE-10285] - Advanced Config field tooltip error#13465
hana-akamai wants to merge 2 commits intolinode:developfrom
hana-akamai:UIE-10285-advanced-config-field-tooltip-error

Conversation

@hana-akamai
Copy link
Contributor

@hana-akamai hana-akamai commented Mar 4, 2026

Description 📝

Fix browser tooltip error shown when updating mysql.group_concat_max_len with value 9007199254740990.6

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Target release date 🗓️

Next release

Preview 📷

Before After
before.mov
after.mov

How to test 🧪

Prerequisites

(How to setup test environment)

  • Have a mysql Database cluster created

Reproduction steps

(How to reproduce the issue, if applicable)

  • On develop or another branch, go to a mysql Database cluster's Advanced Configuration tab
  • Add mysql.group_concat_max_len if the config option has not already been added
  • Edit the mysql.group_concat_max_len value to 9007199254740990.6 and click Save
  • There should be a browser tooltip error

Verification steps

(How to verify changes)

  • Pull this PR or use the Preview link, go to a mysql Database cluster's Advanced Configuration tab
  • Add mysql.group_concat_max_len if the config option has not already been added
  • Edit the mysql.group_concat_max_len value to 9007199254740990.6 and click Save
  • There should not be a browser tooltip error and the value should round up to 9007199254740991

@hana-akamai hana-akamai self-assigned this Mar 4, 2026
@hana-akamai hana-akamai added Bug Fixes for regressions or bugs DBaaS Relates to Database as a Service labels Mar 4, 2026
@hana-akamai hana-akamai marked this pull request as ready for review March 4, 2026 21:19
@hana-akamai hana-akamai requested a review from a team as a code owner March 4, 2026 21:19
@hana-akamai hana-akamai requested a review from smans-akamai March 4, 2026 21:19
}
slotProps={{
htmlInput: {
step: 'any', // UIE-10285: Fix edge-case tooltip
Copy link
Contributor Author

@hana-akamai hana-akamai Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allow any value and let user agent round to the nearest value https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/input/number#step

Copy link
Contributor

@smans-akamai smans-akamai Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does every numeric field for advanced configuration not accept floats? If so, then would this cause it to round behind the scenes every time or only in certain cases? As an alternative, would it make sense to provide an inline error when floats are provided to the input like we do with some of the other validation?

Since this would apply the change to all the number and integer fields in the config response I was curious about the behavior.

Copy link
Contributor

@smans-akamai smans-akamai Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like it does throw this type of validation error when I reduce the value for group_concat_max_len to 900719925474099.6 so maybe this is an issue with the size of the number and the validation?

Screenshot 2026-03-05 at 4 42 25 PM

From the schema, it looks like the integer fields are set up to throw validation errors for floats while Number fields won't. Would this rounding behavior only get applied to the integer fields?

Copy link
Contributor

@smans-akamai smans-akamai Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find any number config fields for MySQL clusters, so I tested this with one in PostgreSQL.
I used shared_buffers_percentage that has the highest max value I could find at 60 and decimal values were being provided as expected. I'm not sure why the integer validation isn't being applied in the original case, but this doesn't seem to effect the behavior for number fields

Screenshot 2026-03-05 at 5 11 21 PM

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 3 failing tests on test run #2 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
3 Failing866 Passing11 Skipped38m 14s

Details

Failing Tests
SpecTest
account-switching.spec.tsCloud Manager Cypress Tests→Parent/Child account switching→From Child to Parent » can switch from Proxy user back to Parent account user from Billing page
account-switching.spec.tsCloud Manager Cypress Tests→Parent/Child account switching→From Child to Child » can switch to another Child account as a Proxy user
object-storage.e2e.spec.tsCloud Manager Cypress Tests→object storage end-to-end tests » can create and delete object storage buckets

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/parentChild/account-switching.spec.ts,cypress/e2e/core/objectStorage/object-storage.e2e.spec.ts"

Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verification steps ✅
Code review ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Fixes for regressions or bugs DBaaS Relates to Database as a Service

Projects

Status: Review

Development

Successfully merging this pull request may close these issues.

4 participants