fix: [UIE-10285] - Advanced Config field tooltip error#13465
fix: [UIE-10285] - Advanced Config field tooltip error#13465hana-akamai wants to merge 2 commits intolinode:developfrom
Conversation
| } | ||
| slotProps={{ | ||
| htmlInput: { | ||
| step: 'any', // UIE-10285: Fix edge-case tooltip |
There was a problem hiding this comment.
Allow any value and let user agent round to the nearest value https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/input/number#step
There was a problem hiding this comment.
Does every numeric field for advanced configuration not accept floats? If so, then would this cause it to round behind the scenes every time or only in certain cases? As an alternative, would it make sense to provide an inline error when floats are provided to the input like we do with some of the other validation?
Since this would apply the change to all the number and integer fields in the config response I was curious about the behavior.
There was a problem hiding this comment.
It looks like it does throw this type of validation error when I reduce the value for group_concat_max_len to 900719925474099.6 so maybe this is an issue with the size of the number and the validation?
From the schema, it looks like the integer fields are set up to throw validation errors for floats while Number fields won't. Would this rounding behavior only get applied to the integer fields?
There was a problem hiding this comment.
I couldn't find any number config fields for MySQL clusters, so I tested this with one in PostgreSQL.
I used shared_buffers_percentage that has the highest max value I could find at 60 and decimal values were being provided as expected. I'm not sure why the integer validation isn't being applied in the original case, but this doesn't seem to effect the behavior for number fields
Cloud Manager UI test results🔺 3 failing tests on test run #2 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/parentChild/account-switching.spec.ts,cypress/e2e/core/objectStorage/object-storage.e2e.spec.ts" |
|||||||||||||||||||||||
dwiley-akamai
left a comment
There was a problem hiding this comment.
Verification steps ✅
Code review ✅


Description 📝
Fix browser tooltip error shown when updating
mysql.group_concat_max_lenwith value9007199254740990.6Scope 🚢
Upon production release, changes in this PR will be visible to:
Target release date 🗓️
Next release
Preview 📷
before.mov
after.mov
How to test 🧪
Prerequisites
(How to setup test environment)
Reproduction steps
(How to reproduce the issue, if applicable)
mysql.group_concat_max_lenif the config option has not already been addedmysql.group_concat_max_lenvalue to9007199254740990.6and click SaveVerification steps
(How to verify changes)
mysql.group_concat_max_lenif the config option has not already been addedmysql.group_concat_max_lenvalue to9007199254740990.6and click Save9007199254740991