fix(dhl): use getGatewayURL() for sandbox mode support in XML quotes#40502
Open
lbajsarowicz wants to merge 1 commit intomagento:2.4-developfrom
Open
fix(dhl): use getGatewayURL() for sandbox mode support in XML quotes#40502lbajsarowicz wants to merge 1 commit intomagento:2.4-developfrom
lbajsarowicz wants to merge 1 commit intomagento:2.4-developfrom
Conversation
Replace hardcoded gateway_xml_url config with getGatewayURL() method call in _getQuotes(). The getGatewayURL() method correctly handles sandbox mode by returning sandbox_xml_url when sandbox_mode is enabled. Without this fix, DHL always returns "Validation Failure: Site Id is wrong" when sandbox mode is enabled because it uses production URL with sandbox credentials. Fixes magento#40249
|
Hi @lbajsarowicz. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
Contributor
Author
|
@magento run all tests |
Contributor
Author
|
@magento run Functional Tests B2B, Functional Tests EE, Functional Tests CE |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace hardcoded
gateway_xml_urlconfig withgetGatewayURL()method call in_getQuotes().The
getGatewayURL()method correctly handles sandbox mode by checkingsandbox_modeconfig and returning the appropriate URL:gateway_xml_urlsandbox_xml_urlRoot cause: Line 1092 in
_getQuotes()used$this->getConfigData('gateway_xml_url')directly, bypassing the sandbox mode logic ingetGatewayURL().Related Pull Requests
None
Fixed Issues (if relevant)
Manual testing scenarios
Questions or comments
The
getGatewayURL()method already exists and handles sandbox mode correctly for other DHL operations. This fix ensures_getQuotes()uses the same logic.Contribution checklist
⭐ Support my work
Do you like the fix? Remember to react with "👍🏻" to get it merged faster,
Then Sponsor me on Github so I can spend more time on fixing issues like this one.
Learn more at https://github.com/sponsors/lbajsarowicz