Fix setup:db:status not recognizing JSON type in MariaDB#40507
Open
lbajsarowicz wants to merge 1 commit intomagento:2.4-developfrom
Open
Fix setup:db:status not recognizing JSON type in MariaDB#40507lbajsarowicz wants to merge 1 commit intomagento:2.4-developfrom
lbajsarowicz wants to merge 1 commit intomagento:2.4-developfrom
Conversation
…CK constraints MariaDB stores JSON columns as LONGTEXT internally but adds a json_valid() CHECK constraint. This caused setup:db:status to always report schema mismatches for JSON columns when using MariaDB. The fix queries information_schema.CHECK_CONSTRAINTS to detect columns with json_valid constraints and corrects their type from 'longtext' to 'json'. Fixes magento#38278
|
Hi @lbajsarowicz. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
Contributor
Author
|
@magento run all tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (*)
Fixes
bin/magento setup:db:statusincorrectly reporting schema mismatches for JSON columns when using MariaDB.Root Cause: When reading column definitions from
information_schema.COLUMNS, MariaDB reports JSON columns withDATA_TYPE = 'longtext'instead ofjson. This causes the schema comparison to always fail because the declared schema saysjsonbut the actual database reportslongtext.Solution: Query
information_schema.CHECK_CONSTRAINTSto find columns withjson_valid()CHECK constraints (which MariaDB automatically adds for JSON columns) and correct their type fromlongtexttojsonbefore comparison.Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
quotetable has JSON columns in recent versions)bin/magento setup:db:statusQuestions or comments
Contribution checklist (*)
⭐ Support my work
Do you like the fix? Remember to react with "👍🏻" to get it merged faster,
Then Sponsor me on Github so I can spend more time on fixing issues like this one.
Learn more at https://github.com/sponsors/lbajsarowicz